fix(cache): exclude node_modules/.vite-temp from cache input tracking#1096
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 26, 2026
Merged
fix(cache): exclude node_modules/.vite-temp from cache input tracking#1096graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
fix-1095
branch
2 times, most recently
from
b7769b9 to
b433227
Compare
fengmk2
changed the title
branchseer
approved these changes
Mar 26, 2026
Merge activity
|
…#1096) ## Summary - Bump vite-task to [2663222c](voidzero-dev/vite-task#296) which merges synthetic task's `input` config with parent cache config and supports `GlobWithBase` with `InputBase::Workspace` - Add `!node_modules/.vite-temp/**` negative input glob (workspace-root-relative) to Pack and Build subcommands - Update test for `trailing_var_arg` CLI parsing change - Add comprehensive snap tests for cache behavior Vite writes transient compiled config files to `node_modules/.vite-temp/` during builds. These files were tracked by fspy as both read and written, causing a read-write overlap that prevented caching ("not cached because it modified its input"). The fix passes `!node_modules/.vite-temp/**` as a `GlobWithBase { base: InputBase::Workspace }` negative glob via `EnabledCacheConfig.input` on Pack and Build subcommands. vite-task PR [#296](voidzero-dev/vite-task#296) ensures this glob is resolved relative to the workspace root and merged into the parent task's input config. vite-task changelog: voidzero-dev/vite-task@69cc6eb...2663222#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed ## Snap tests | Test | Verifies | | --- | --- | | `command-pack-monorepo` | cache hit (root + sub dir), source change miss, direct `vp pack` not cached | | `vp-build-cache` | cache hit via `vp run`, direct `vp build` not cached | | `vp-build-cache-monorepo` | cache hit (root + sub dir), source change miss, direct `vp build` not cached | | `vp-pack-cache-disabled` | `cache: false` disables caching for `vp pack` | | `vp-build-cache-disabled` | `cache: false` disables caching for `vp build` | ## Test plan - [x] `cargo check` and `cargo test` pass (with `-D warnings`) - [x] All snap tests pass locally - [x] CI passes on all platforms Closes #1095 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
fix-1095
branch
from
9297687 to
5f52b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputconfig with parent cache config and supportsGlobWithBasewithInputBase::Workspace!node_modules/.vite-temp/**negative input glob (workspace-root-relative) to Pack and Build subcommandstrailing_var_argCLI parsing changeVite writes transient compiled config files to
node_modules/.vite-temp/during builds. These files were tracked by fspy as both read and written, causing a read-write overlap that prevented caching ("not cached because it modified its input").The fix passes
!node_modules/.vite-temp/**as aGlobWithBase { base: InputBase::Workspace }negative glob viaEnabledCacheConfig.inputon Pack and Build subcommands. vite-task PR #296 ensures this glob is resolved relative to the workspace root and merged into the parent task's input config.vite-task changelog: voidzero-dev/vite-task@69cc6eb...2663222#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
Snap tests
command-pack-monorepovp packnot cachedvp-build-cachevp run, directvp buildnot cachedvp-build-cache-monorepovp buildnot cachedvp-pack-cache-disabledcache: falsedisables caching forvp packvp-build-cache-disabledcache: falsedisables caching forvp buildTest plan
cargo checkandcargo testpass (with-D warnings)Closes #1095
🤖 Generated with Claude Code